refactor: make rpc reader use account map #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yael-Starkware
approved these changes
Jul 14, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)
giladchase
force-pushed
the
gilad/generlaize-test-rpc-state-reader
branch
from
2129597 to
db9ecef
Compare
dafnamatsry
approved these changes
Jul 14, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
giladchase
force-pushed
the
gilad/generlaize-test-rpc-state-reader
branch
from
db9ecef to
894d522
Compare
This finishes the refactor started at #454.
giladchase
force-pushed
the
gilad/test-rpc-finish-generalize
branch
from
fbf4f87 to
dd851e7
Compare
giladchase
commented
Jul 15, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @dafnamatsry and @Yael-Starkware)
giladchase
commented
Jul 15, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes the refactor started at #454, plz view that PR for context.
This change is